Merge pull request #4 from fbarresi/master

Fixed variable length for double types

.github/workflows/dotnet-core.yml

@@ -18,14 +18,16 @@ jobs:
       uses: actions/setup-dotnet@v1
       with:
         dotnet-version: 5.0.x
+    - name: Install NUnit.ConsoleRunner
+      run: nuget install NUnit.ConsoleRunner -Version 3.13.0 -DirectDownload -OutputDirectory .       
     - name: Install dependencies
       run: dotnet restore
     - name: Build
       run: dotnet build --configuration Release --no-restore /p:version=1.1.${{ github.run_number }}
+    - name: Tests
+      run: ./NUnit.ConsoleRunner.3.13.0/tools/nunit3-console.exe  "Sharp7.Rx.Tests\bin\Release\net461\Sharp7.Rx.Tests.dll"
     - name: NugetPublish
       run: dotnet nuget push Sharp7.Rx\bin\Release\Sharp7.Rx.1.1.${{ github.run_number }}.nupkg -s https://api.nuget.org/v3/index.json -k ${{ secrets.NUGET_DEPLOY_KEY }}
-    - name: Test
-      run: dotnet test --no-restore --verbosity normal
     - name: Create Release
       id: create_release
       uses: actions/create-release@v1

README.md

@@ -1,6 +1,6 @@
 # Sharp7Reactive
 
-[![Build status](https://ci.appveyor.com/api/projects/status/91sbafe4y6c53fgi?svg=true)](https://ci.appveyor.com/project/fbarresi/sharp7reactive)
+[![.NET Core Build](https://github.com/evopro-ag/Sharp7Reactive/actions/workflows/dotnet-core.yml/badge.svg)](https://github.com/evopro-ag/Sharp7Reactive/actions/workflows/dotnet-core.yml)
 ![Licence](https://img.shields.io/github/license/evopro-ag/Sharp7Reactive.svg)
 [![Nuget Version](https://img.shields.io/nuget/v/Sharp7.Rx.svg)](https://www.nuget.org/packages/Sharp7.Rx/)
 

Sharp7.Rx.Tests/ParsingS7VariableName.feature

@@ -31,7 +31,7 @@ Scenario: Parsing variable name for bool
 	| Db      | 5    | 887   | 20     | 0   | String   |
 	| Db      | 506  | 216   | 1      | 0   | Byte     |
 	| Db      | 506  | 216   | 5      | 0   | Byte     |
-	| Db      | 506  | 216   | 0      | 0   | Double   |
+	| Db      | 506  | 216   | 4      | 0   | Double   |
 	| Db      | 506  | 216   | 4      | 0   | DInteger |
 	| Db      | 506  | 216   | 2      | 0   | Integer  |
 	| Db      | 506  | 216   | 2      | 0   | Integer  |

Sharp7.Rx.Tests/ParsingS7VariableName.feature.cs

@@ -186,7 +186,7 @@ this.ScenarioInitialize(scenarioInfo);
                         "Db",
                         "506",
                         "216",
-                        "0",
+                        "4",
                         "0",
                         "Double"});
             table2.AddRow(new string[] {

Sharp7.Rx/S7VariableNameParser.cs

@@ -74,6 +74,10 @@ namespace Sharp7.Rx
                 {
                     s7VariableAddress.Length = 8;
                 }
+                else if (type == DbType.Double)
+                {
+                    s7VariableAddress.Length = 4;
+                }
 
                 return s7VariableAddress;
             }